Add 502 to specific list of retryable HTTP errors #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstoick
force-pushed
the
feat/add-502-to-retryable-errors
branch
from
bee75c7 to
2638cf1
Compare
alexstoick
changed the title
vmakuh
approved these changes
Jul 12, 2024
Fix an issue where we check the code (string) presence in an array of Int values.
alexstoick
force-pushed
the
feat/add-502-to-retryable-errors
branch
from
2638cf1 to
3ca8f3c
Compare
| @@ -223,7 +223,7 @@ def raise_on_bad_response(response) | |||
| def retryable_http_response_code?(code) | |||
| # retry (in order): bad request, forbidden (token expired in flight), method not allowed, | |||
| # request timeout, too many requests, anything in the 500 range (504 is fairly common) | |||
| [400, 403, 405, 408, 429, 504].include?(code.to_i) || (500..599).include?(code) | |||
| [400, 403, 405, 408, 429, 502, 504].include?(code.to_i) || (500..599).include?(code.to_i) | |||
There was a problem hiding this comment.
@alexstoick is this the same as
[400, 403, 405, 408, 429].include?(code.to_i) || (500..599).include?(code.to_i)? i.e. is it redundant to have 502 and 504 in the first list?
There was a problem hiding this comment.
yep... that is indeed redundant now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where we check the code (string) presence in an array of
Int values.