fix crash by clicking on candidates when librime-predict enabled #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
reviewed
Jan 3, 2024
WeaselTSF/CandidateList.cpp
Outdated
| inputs[0].ki = {VK_PRIOR, 0,0,0,0}; | ||
| inputs[1].type = INPUT_KEYBOARD; | ||
| inputs[1].ki = {VK_PRIOR, 0,KEYEVENTF_KEYUP,0,0}; | ||
| ::SendInput(sizeof(inputs) / sizeof(INPUT), inputs, sizeof(INPUT)); |
There was a problem hiding this comment.
I guess we can try to defer the _UpdateComposition call, or send an input key right here.
Sending an input key to the system essentially postpones the key event handling.
There was a problem hiding this comment.
if we only do _UpdateComposition here, the crash is fixed, however the prediction will not shown until next key press comes.
There was a problem hiding this comment.
How did the crash happen?
How is it fixed then?
There was a problem hiding this comment.
How did the crash happen?
How is it fixed then?
maybe some object is referenced after released, after prediction is enabled and clicking select on non-prediction candidate
maybe some status different from space-selecting or auto-committing.
lotem
reviewed
Jan 4, 2024
…al candidate and there are predictions.
fxliang
force-pushed
the
predict-crash
branch
from
46f32c9 to
bb58b8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.