Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix c1f24cf. and add error detection in ci workflow. #1036

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix c1f24cf. and add error detection in ci workflow. #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/commit-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@ jobs:
.\build.bat data
.\build.bat hant
.\build.bat installer

if: ${{ success() }}

- name: Compress Debug Symbols
shell: pwsh
run: |
Compress-Archive -Path output\*.pdb -CompressionLevel Optimal -DestinationPath .\output\archives\symbols.zip
if: ${{ success() }}

- name: Upload artifacts
uses: actions/upload-artifact@v3
Expand All @@ -68,3 +70,4 @@ jobs:
path: |
.\output\archives\weasel*.exe
.\output\archives\symbols.zip
if: ${{ success() }}
4 changes: 4 additions & 0 deletions .github/workflows/release-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,19 @@ jobs:
.\build.bat data
.\build.bat hant
.\build.bat installer
if: ${{ success() }}

- name: Compress Debug Symbols
shell: pwsh
run: |
Compress-Archive -Path output\*.pdb -CompressionLevel Optimal -DestinationPath .\output\archives\symbols.zip
if: ${{ success() }}

- name: Extract changelog
shell: pwsh
run: |
.\extract_changelog.ps1
if: ${{ success() }}

- name: Release
uses: softprops/action-gh-release@v1
Expand All @@ -68,3 +71,4 @@ jobs:
./output/archives/weasel*.exe
./output/archives/symbols.zip
body_path: ${{ github.workspace }}/RELEASE_CHANGELOG.md
if: ${{ success() }}
2 changes: 1 addition & 1 deletion RimeWithWeasel/RimeWithWeasel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ static void _UpdateUIStyle(RimeConfig* config, UI* ui, bool initialize)
{std::string("vertical"), true}
};
bool _text_orientation_bool = false;
_RimeParseStringOptWithFallback(config, "style/text_orientation", _text_orientation_bool, _text_orientation, false);
_RimeParseStringOpt(config, "style/text_orientation", _text_orientation_bool, _text_orientation);
if(_text_orientation_bool)
style.layout_type = UIStyle::LAYOUT_VERTICAL_TEXT;
_RimeGetStringWithFunc(config, "style/label_format", style.label_text_format);
Expand Down