Merge UI improvement to OpenTracks #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, user does not have to hold the button
…e recording to stop without crashing once paused.
…me button clicked.
…l time (jumps after resuming).
…y to re-open it while track is still running)
…y to re-open it while track is still running)
--NOTE: Needs changes among selecting multiple options
…time is paused exclusively, total time keeps running while paused.
…time is paused exclusively, total time keeps running while paused. (cherry picked from commit 48f11af)
(cherry picked from commit ab27ed9)
… to TrackRecording.xml
… will reside within the finish button.
…wenty. Program now runs.
…tTime # Conflicts: # src/main/java/de/dennisguse/opentracks/settings/DefaultsSettingsFragment.java # src/main/res/values/settings.xml
…turn it into an int. Comparison is then made with the total time of the track.
…ng user selection and comparing to total track time.
…tTime # Conflicts: # src/main/java/de/dennisguse/opentracks/settings/DefaultsSettingsFragment.java
…lects Custom again.
Resolved an issue where a track could not be deleted because the set customized time in "Preferred minimum time" always returned a null value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group 1: UI modifications
Describe the pull request
Improvement to the UI of the OpenTracks application, specifically developing Start/Stop buttons with recording functionality, modifying the pause button to stop recording immediately (instead of having to hold it), the code for avoiding NullPointerException and the floating button to match with stop/start button, and finally creating and improving certain buttons to upgrade the UI, making the application more intuitive.
Link to the the issue
(If available): The link to the issue that this pull request solves.
License agreement
By opening this pull request, you are providing your contribution under the Apache License 2.0 (see LICENSE.md).