Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame Handling Improvements #333

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Frame Handling Improvements #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8862184
fix: lifetimes in Program#get_frames_for_instruction
kalzoo Jan 17, 2024
6c5d96a
feat: derive Default for MatchedFrames
kalzoo Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion quil-rs/src/program/frame.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ pub(crate) struct FrameMatchConditions<'a> {
}

/// The product of evaluating [`FrameMatchConditions`] in the scope of available frames (such as within a [`crate::Program`]).
#[derive(Debug)]
#[derive(Debug, Default)]
pub struct MatchedFrames<'a> {
/// Which concrete frames are blocked and not used.
/// This set is mutually exclusive with `used`.
Expand Down
8 changes: 4 additions & 4 deletions quil-rs/src/program/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,10 @@
///
/// See the [Quil-T spec](https://github.com/quil-lang/quil/blob/master/rfcs/analog/proposal.md)
/// for more information.
pub fn get_frames_for_instruction<'a>(
&'a self,
instruction: &'a Instruction,
) -> Option<MatchedFrames<'a>> {
pub fn get_frames_for_instruction<'i, 'p>(

Check failure on line 288 in quil-rs/src/program/mod.rs

View workflow job for this annotation

GitHub Actions / Clippy (stable) 

the following explicit lifetimes could be elided: 'i
&'p self,
instruction: &'i Instruction,
) -> Option<MatchedFrames<'p>> {
let qubits_used_by_program = self.get_used_qubits();

instruction
Expand Down
Loading