Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Valid instructions will no longer be rejected by the compatibility layer #1742

Merged
merged 5 commits into from
Feb 22, 2024
Merged

fix: Valid instructions will no longer be rejected by the compatibility layer #1742

merged 5 commits into from
Feb 22, 2024

Conversation

MarquessV
Copy link
Contributor

Description

closes #1740

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@MarquessV MarquessV linked an issue Feb 21, 2024 that may be closed by this pull request
_convert_to_py_instruction is non-exhaustive #1740
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7148 6297 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/quilbase.py 94% 🟢
TOTAL 94% 🟢

updated for commit: dd1d6fd by action🐍

@MarquessV MarquessV marked this pull request as ready for review February 21, 2024 21:36
@MarquessV MarquessV requested a review from a team as a code owner February 21, 2024 21:36
Shadow53
Shadow53 approved these changes Feb 21, 2024
View reviewed changes
pyquil/quilbase.py Show resolved Hide resolved
@MarquessV MarquessV enabled auto-merge (squash) February 22, 2024 20:52
@MarquessV MarquessV disabled auto-merge February 22, 2024 20:52
@MarquessV MarquessV merged commit 71391c5 into master Feb 22, 2024
22 checks passed
@MarquessV MarquessV deleted the 1740-_convert_to_py_instruction-is-non-exhaustive branch February 22, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow53 Shadow53 Shadow53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_convert_to_py_instruction is non-exhaustive
2 participants
@MarquessV @Shadow53