Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove pydantic dependency #1738

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

mac01021
Copy link
Contributor

Description

Insert your PR description here. Thanks for contributing to pyQuil! 🙂

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@mac01021 mac01021 requested a review from a team as a code owner February 13, 2024 20:05
@mac01021 mac01021 force-pushed the expunge-pydantic branch 5 times, most recently from d9014f9 to 301b8e7 Compare February 13, 2024 21:19
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth getting rid of Pydantic since we use it in such a limited way, and it should simplify dependency management for consumers of pyQuil. I have a few questions about leaning on built-in @dataclass behavior, and why some fields moved around, but I'm liking where this is heading.

For reference, some important places these models are used:

pyquil/quantum_processor/transformers/compiler_isa_to_graph.py
pyquil/quantum_processor/transformers/qcs_isa_to_compiler_isa.py
pyquil/noise_gates.py

pyquil/external/rpcq.py Outdated Show resolved Hide resolved
pyquil/external/rpcq.py Outdated Show resolved Hide resolved
pyquil/external/rpcq.py Show resolved Hide resolved
@MarquessV
Copy link
Contributor

If you rebase your branch, you should hopefully pull in a fix for the failed test check.

pyquil/external/rpcq.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One place to cleanup an old comment, but LGTM!

test/unit/conftest.py Show resolved Hide resolved
test/unit/test_graph.py Show resolved Hide resolved
@MarquessV MarquessV changed the title Remove pydantic dependency chore: Remove pydantic dependency Feb 16, 2024
@MarquessV MarquessV merged commit 754125f into rigetti:master Feb 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants