-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove pydantic dependency #1738
Conversation
d9014f9
to
301b8e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth getting rid of Pydantic since we use it in such a limited way, and it should simplify dependency management for consumers of pyQuil. I have a few questions about leaning on built-in @dataclass
behavior, and why some fields moved around, but I'm liking where this is heading.
For reference, some important places these models are used:
pyquil/quantum_processor/transformers/compiler_isa_to_graph.py
pyquil/quantum_processor/transformers/qcs_isa_to_compiler_isa.py
pyquil/noise_gates.py
If you rebase your branch, you should hopefully pull in a fix for the failed test check. |
425665a
to
9296d96
Compare
9296d96
to
5adf61e
Compare
1a46fae
to
8b409b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One place to cleanup an old comment, but LGTM!
Description
Insert your PR description here. Thanks for contributing to pyQuil! 🙂
Checklist
master
branch