Add deprecated property to DefFrame for CHANNEL-DELAY attribute #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarquessV Given that I've written this, are you willing to merge it? Or do you view it as a step in the wrong directions? |
MarquessV
reviewed
Jan 30, 2024
test/unit/test_quilbase.py
Outdated
| # center_frequency, | ||
| # channel_delay]: | ||
| # if arg is not None | ||
| # ] |
There was a problem hiding this comment.
Do we still need these comments?
There was a problem hiding this comment.
I've removed them!
kalzoo
approved these changes
Jan 30, 2024
test/unit/test_quilbase.py
Outdated
| channel_delay: Optional[float], | ||
| ) -> DefFrame: | ||
| optional_args = {k: v | ||
| for k, v in locals().items() |
There was a problem hiding this comment.
this is probably more python magic than we want or need
There was a problem hiding this comment.
I disenchanted it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v4 has added deprecated attribute properties for all the standard defframe attributes, except for CHANNEL-DELAY. I have a bunch of call sites in my v3 codebase that use this attribute and engineers like to benefit from autocompletion in their IDE when accessing channel delays. So here is a PR that adds the missing property.
Checklist
masterbranch