Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ResetQubit instructions will not be returned as Reset after being inserted into a Program #1727

Conversation

MarquessV
Copy link
Contributor

Description

closes #1726

Thanks to @mac01021 for the report!

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@MarquessV MarquessV requested a review from a team as a code owner January 22, 2024 20:56
@rigetti-githubbot
Copy link

rigetti-githubbot commented Jan 22, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7130 6253 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/quilbase.py 93% 🟢
TOTAL 93% 🟢

updated for commit: 140e079 by action🐍

Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The multiple assertions for the correct type seem maybe superfluous, but better there than not, I suppose.

test/unit/test_program.py Show resolved Hide resolved
test/unit/test_program.py Show resolved Hide resolved
pyquil/quilbase.py Outdated Show resolved Hide resolved
@mac01021
Copy link
Contributor

While you're in here, can you check to see if the same kind of thing needs to happen for Delay and DelayFrames?

@MarquessV
Copy link
Contributor Author

While you're in here, can you check to see if the same kind of thing needs to happen for Delay and DelayFrames?

Done!

@MarquessV MarquessV merged commit cbf9ac7 into master Feb 1, 2024
22 checks passed
@MarquessV MarquessV deleted the 1726-resetqubit-always-gets-returned-as-reset-from-the-compatibility-layer branch February 1, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResetQubit always gets returned as Reset from the compatibility layer.
4 participants