Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update new QPU compiler backend documentation #1708

Merged
merged 17 commits into from
Dec 8, 2023

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Dec 7, 2023

Description

closes #1707 and #1709

@MarquessV MarquessV requested a review from a team as a code owner December 7, 2023 18:33
@rigetti-githubbot
Copy link

rigetti-githubbot commented Dec 7, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7057 6190 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/api/_compiler.py 56% 🟢
TOTAL 56% 🟢

updated for commit: 68c71cd by action🐍

Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but otherwise looks good

docs/source/introducing_v4.rst Outdated Show resolved Hide resolved
docs/source/introducing_v4.rst Outdated Show resolved Hide resolved

api_options = QPUCompilerAPIOptions()
api_options.use_backend_v2()
api_options.v2(
# See API docs for QPUCompilerAPIOptions for more information on this and other parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two problems:

  1. There isn't a great way to link inside of the code block as far as I can tell, but this isn't such a big deal because it is linked in the description above the code block.

  2. Unfortunately, sphinx doesn't forward the docs from the aliased class and it won't render the docstring for a type alias. I've updated the documentation here to link to the type hints for now, but once qcs-sdk-python has live docs, we can link to it directly.

@MarquessV MarquessV merged commit 1397bae into master Dec 8, 2023
22 checks passed
@MarquessV MarquessV deleted the update-translation-options-example branch December 8, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for the new compiler backend
4 participants