Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update qcs_sdk to add ability to modify TranslationOptions #1706

Merged
merged 3 commits into from
Dec 6, 2023
Merged

feat: update qcs_sdk to add ability to modify TranslationOptions #1706

merged 3 commits into from
Dec 6, 2023

Conversation

Shadow53
Copy link
Contributor

@Shadow53 Shadow53 commented Dec 5, 2023

Description

This propagates the changes from rigetti/qcs-sdk-rust#406 up to PyQuil by updating the dependency version of qcs_sdk.

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@Shadow53 Shadow53 requested a review from a team as a code owner December 5, 2023 23:41
@rigetti-githubbot
Copy link

rigetti-githubbot commented Dec 5, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7089 6222 88% 87% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: ac63c06 by action🐍

MarquessV
MarquessV approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to set the passive reset delay to 200 microseconds, nice!

@Shadow53 Shadow53 merged commit 1f1bb06 into master Dec 6, 2023
21 checks passed
@Shadow53 Shadow53 deleted the update-qcs-sdk branch December 6, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarquessV MarquessV MarquessV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shadow53 @rigetti-githubbot @MarquessV