Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update qcs-sdk-python version for libquil support, and document libquil usage #1698

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Update qcs-sdk-python version for libquil support, and document libquil usage #1698

merged 6 commits into from
Jan 26, 2024

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Nov 22, 2023 •
edited
Loading

This MR

  • updates the qcs-sdk-python version to 0.14.0 which introduces support libquil as a quilc and QVM "client"
  • updates the Advanced Usage section of the documentation to describe how to use libquil in pyQuil
  • slightly lowers the threshold of one test (seems like a possible regression in Quilc resulting in slightly lower program fidelity when testing locally)
  • fix an issue from new: Quilc client support #1637 where a client wasn't being passed

@notmgsk notmgsk requested a review from a team as a code owner November 22, 2023 16:17
@rigetti-githubbot
Copy link

rigetti-githubbot commented Nov 22, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7099 6225 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/api/_compiler.py 56% 🟢
TOTAL 56% 🟢

updated for commit: 9103613 by action🐍

BatmanAoD
BatmanAoD approved these changes Jan 10, 2024
View reviewed changes
Copy link

@BatmanAoD BatmanAoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a ticket for the possible regression? (Or any other reminder to investigate at some point?)

Approving because I don't see why that should block this particular change

@notmgsk notmgsk merged commit 3ef048c into master Jan 26, 2024
22 checks passed
@notmgsk notmgsk deleted the 1691-libquil branch January 26, 2024 15:31
@notmgsk notmgsk mentioned this pull request Feb 20, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BatmanAoD BatmanAoD BatmanAoD approved these changes

@MarquessV MarquessV Awaiting requested review from MarquessV

@Shadow53 Shadow53 Awaiting requested review from Shadow53

@kalzoo kalzoo Awaiting requested review from kalzoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notmgsk @rigetti-githubbot @BatmanAoD