Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The execution_options property is now used for retrieving results if no overriding options were provided to the execute method. #1694

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: The execution_options property is now used for retrieving results if no overriding options were provided to the execute method. #1694

merged 1 commit into from
Nov 15, 2023

Conversation

MarquessV
Copy link
Contributor

Description

Closes #1693

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@MarquessV
fix: The execution_options property is now used for retrieving
d365c38 
results if no overriding options were provided to the ``execute``
method.
@MarquessV MarquessV linked an issue Nov 15, 2023 that may be closed by this pull request
Bug: QPU.execution_options not used for QPU.retrieve_results #1693
Closed
@MarquessV MarquessV marked this pull request as ready for review November 15, 2023 19:54
@MarquessV MarquessV requested a review from a team as a code owner November 15, 2023 19:54
@rigetti-githubbot
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7051 6185 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/api/_qpu.py 65% 🟢
TOTAL 65% 🟢

updated for commit: d365c38 by action🐍

kalzoo
kalzoo approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@kalzoo kalzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nailed it! 🔨

@MarquessV MarquessV merged commit f6d6824 into master Nov 15, 2023
19 checks passed
@MarquessV MarquessV deleted the 1693-bug-qpuexecution_options-not-used-for-qpuretrieve_results-1 branch November 15, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalzoo kalzoo kalzoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: QPU.execution_options not used for QPU.retrieve_results
3 participants
@MarquessV @rigetti-githubbot @kalzoo