Added a failing test for conditional operator nullable conversions #1746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a test case
BindingCompiler_ImplicitConversion_ConditionalNullableAndNonNullable
for conditional operators that cannot compile:It seems to me that the VisitConditionalExpression can do both implicit conversions (from nullable double to double and vice versa) and cannot decide on the direction.
Shall we be even able to do an implicit conversion from nullable to non-nullable?
I am not sure if I can fix it in the logic of implicit conversion, or if it is a special case here.