some patch code for tab and table #56
Conversation
| @@ -68,6 +69,10 @@ type Panel struct { | |||
| TooltipImmediate bool | |||
| } | |||
|
|
|||
| func (p *Panel) SetParent(panel *Panel) { | |||
There was a problem hiding this comment.
As I think I've stated before, I will not add a .SetParent(*Panel) method. If you want to set the parent, call .AddChild(Paneler) or .AddChildAtIndex(Paneler,int) on the parent instead. This will ensure all of the other things that clients expect to happen, do happen, unlike with what this method is doing.
| @@ -15,6 +15,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/richardwilkes/toolbox" | |||
|
|
|||
| @@ -13,6 +13,7 @@ import ( | |||
| "strconv" | |||
|
|
|||
| "github.com/richardwilkes/toolbox/i18n" | |||
|
|
|||
There was a problem hiding this comment.
This is goland's import grouping, it will also automatically separate it if you change it manually
| @@ -49,6 +50,11 @@ type dockHeader struct { | |||
| dragInsertIndex int | |||
| } | |||
|
|
|||
| func (d *dockHeader) CurrentDockTabLabel() *Label { | |||
There was a problem hiding this comment.
Why is this needed? If you want to know the title of the current tab, you can call .CurrentDockable().Title(). There is no need to access it from here.
There was a problem hiding this comment.
No, title is just a string not a panel, we need to get the label where the title is located in order to add a context menu in its coordinates to close all the tabs with one click.
| @@ -50,6 +50,9 @@ func NewDockContainer(dock *Dock, dockable Dockable) *DockContainer { | |||
| d.AddChild(d.content) | |||
| return d | |||
| } | |||
| func (d *DockContainer) Header() *dockHeader { | |||
There was a problem hiding this comment.
Returning a private struct from a public API is not acceptable. Why do you feel you need to get access to this private, internal, field? It is being protected specifically to help prevent unexpected changes to its state and as such, I'm unlikely to want it exposed.
There was a problem hiding this comment.
Without this action there is no way to fetch the dock title's panel
|
The reason for implementing the ability to close all tabs with one click is because I often have a lot of tabs open, like looking at gcs engineering, and while I don't understand what game that is, it's too much of a hassle to close them one by one when I have a lot of forms open within the gcs interface. In addition, code display widgets or edit widgets may also open a lot of tabs, if the function is improved later, it is possible to open a lot of tabs like using goland. So the context menu to close all tabs with one click is very useful for me. Anyway, I tested it on my side and it works fine, so I will close this pr if you think it's not working. |
|
While I won't take the changes in this PR, I did add a contextual menu into the dock tabs which has two options when more than one tab is present in a dock container:
Note that these options only apply to the current dock container and not to any others that may be present elsewhere in the dock. |
No description provided.