Fix #896: display-only pools weren't displaying correctly

richardwilkes · Nov 19, 2024 · 094c4ad · 094c4ad
1 parent 96b9eb6
commit 094c4ad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ux/attr_def_settings_panel.go b/ux/attr_def_settings_panel.go
@@ -200,7 +200,7 @@ func (p *attrDefSettingsPanel) createContent() *unison.Panel {
 		field.Tooltip = newWrappedTooltip(i18n.Text("The base value, which may be a number or a formula"))
 		content.AddChild(field)
 
-		if p.def.Type != attribute.IntegerRef && p.def.Type != attribute.DecimalRef {
+		if p.def.Type != attribute.IntegerRef && p.def.Type != attribute.DecimalRef && p.def.Type != attribute.PoolRef {
 			addLabelAndDecimalField(content, p.dockable.targetMgr, p.def.KeyPrefix+"cost", i18n.Text("Cost per Point"),
 				i18n.Text("The cost per point difference from the base"), &p.def.CostPerPoint, 0, fxp.MaxBasePoints)
 

diff --git a/ux/attr_panel.go b/ux/attr_panel.go
@@ -188,7 +188,11 @@ func (a *AttrPanel) rebuild(attrs *gurps.AttributeDefs) {
 				}
 				a.rowStarts = append(a.rowStarts, len(a.Children()))
 				if a.kind == poolAttrKind {
-					a.AddChild(a.createPointsField(attr))
+					if def.Type != attribute.PoolRef {
+						a.AddChild(a.createPointsField(attr))
+					} else {
+						a.AddChild(unison.NewPanel())
+					}
 
 					var currentField *DecimalField
 					currentField = NewDecimalPageField(a.targetMgr, a.prefix+attr.AttrID+":cur",