Interface specific addresses #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardschneider
force-pushed
the
iface-addr
branch
from
723b659 to
f17dec6
Compare
richardschneider
force-pushed
the
iface-addr
branch
from
3dc5a26 to
153d97c
Compare
jbrestan
reviewed
Sep 3, 2019
| if (mask != null) | ||
| { | ||
| var network = IPNetwork.Parse(local, mask); | ||
| return network.Contains(remote); |
There was a problem hiding this comment.
When testing this on multi-interface setup, I was still seeing some weird results, like my local Hyper-V interface addresses being used in answers to queries sent from remote machines on a completely different network, which I'd expect would be filtered out.
jbrestan
reviewed
Sep 3, 2019
| } | ||
|
|
||
| // Can not determine reachability, assume that network routing can do it. | ||
| return true; |
There was a problem hiding this comment.
Are there no further heuristics we could use if all else fails? Maybe something like local.AddressFamily == remote.AddressFamily? In my multi-interface test setup I was seeing a lot of IPv6 responses that get removed if I add that additional comparison, but I'm not sure if that's right or wrong...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #25