Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to use SHA1 over MD5 to comply with FIPS #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tadgerb
Copy link

@tadgerb tadgerb commented Aug 2, 2021

FIPS enforcement in .Net means that MD5 cannot be used, even for innocuous reasons. This replaces its use with SHA1, which is currently allowed.

@codecov-commenter
Copy link

Codecov Report

Merging #107 (13de5f9) into master (b9f2f81) will decrease coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   91.11%   90.54%   -0.58%     
==========================================
  Files          10       10              
  Lines         518      518              
==========================================
- Hits          472      469       -3     
- Misses         46       49       +3     
Impacted Files Coverage Δ
src/RecentMessages.cs 100.00% <100.00%> (ø)
src/MulticastClient.cs 82.78% <0.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f2f81...13de5f9. Read the comment docs.

@jdomnitz
Copy link

This PR was merged into the fork available here:
https://github.com/jdomnitz/net-mdns

Also available as a Nuget package:
Makaretu.Dns.Multicast.New

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants