Make RecentMessages thread safe

richardschneider · Aug 27, 2019 · 0e72be0 · 0e72be0
1 parent db044dc
commit 0e72be0
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/RecentMessages.cs b/src/RecentMessages.cs
@@ -16,9 +16,6 @@ namespace Makaretu.Dns
     /// </remarks>
     public class RecentMessages
     {
-        // MD5 is okay because the hash is not used for security.
-        HashAlgorithm hasher = MD5.Create();
-
         /// <summary>
         ///   Recent messages.
         /// </summary>
@@ -84,7 +81,11 @@ public int Prune()
         /// </returns>
         public string GetId(byte[] message)
         {
-            return Convert.ToBase64String(hasher.ComputeHash(message));
+            // MD5 is okay because the hash is not used for security.
+            using (HashAlgorithm hasher = MD5.Create())
+            {
+                return Convert.ToBase64String(hasher.ComputeHash(message));
+            }
         }
     }
 }