mvc.Model: add .toJsObject() to retrieve all attrs, including schema/meta/format defs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would it be better to wrap this up in the toJSON() function and pass in true to get back the formatted object. so object.toJSON(true); will pass back a formatted object? or how about calling it .toFormattedObj() or something similar? I'm leaning towards the .toFormattedObj as it's more descriptive and the toJSON is used by JSON.stringify which should save the attributes as is rather than the formatted ones. can you also add in the method to the README? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to, for example, pass the current model state to a template, it would be nice to have a nicely formatted represenation of all attrs available.
.toJson()currently only returns the fields defined inthis.attr_, and the values retrieved dont respect the fields formatters, so I thought adding.toJsObject()might be of help.