Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geolocation.set_notification_ex docs out of sync with reality (iOS) #310

Open
jtara opened this issue May 28, 2015 · 2 comments
Open

Geolocation.set_notification_ex docs out of sync with reality (iOS) #310

jtara opened this issue May 28, 2015 · 2 comments

Comments

@jtara
Copy link

jtara commented May 28, 2015

5.0.38 docs state:

Ruby: Geolocation.set_notification_ex(callback url, string callbackParams, options hash)

JavaScript: Rho.Geolocation.set_notification_ex(callback url, string callbackParams, options hash);

iOS implementation punts by simply calling set_notification. But mis-match in type of third parameter:

void rho_geo_set_notification_ex(const char *url, rho_param* p, char* params) {
    //TODO: rho_geo_set_notification_ex
}

IMO, this is a bug, and I will file an Issue for that.

But the documentation should correspond with reality. At least a note about the bug. It should be stated that this is not implemented for iOS.

Don't know about other platforms.

@jtara
Copy link
Author

jtara commented May 28, 2015

rhomobile/rhodes#635

@jtara
Copy link
Author

jtara commented May 28, 2015

I wasn't very observant!

It doesn't punt to set_notification. It does nothing, and of course will still throw a run-time error if the third parameter is a hash.

Definitely should be documented as "not implemented" for iOS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant