Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoLocation.set_notification_ex third parameter mis-match vs. docs #635

Open
jtara opened this issue May 28, 2015 · 2 comments
Open

GeoLocation.set_notification_ex third parameter mis-match vs. docs #635

jtara opened this issue May 28, 2015 · 2 comments
Assignees

Comments

@jtara
Copy link

jtara commented May 28, 2015

I also filed an Issue with documentation.

5.0.38 docs state:

Ruby: Geolocation.set_notification_ex(callback url, string callbackParams, options hash)>>

JavaScript: Rho.Geolocation.set_notification_ex(callback url, string callbackParams, options hash);
iOS implementation punts by simply calling set_notification. But mis-match in type of third parameter:

void rho_geo_set_notification_ex(const char *url, rho_param* p, char* params) {
    //TODO: rho_geo_set_notification_ex
}

But because the third parameter type mis-matches, (string vs hash) this will not work as documented.

I've suggested that until this is implemented, it should be documented as not implemented for iOS.

I guess you could reconcile this by accepting hash, ignore minDistance, set third parameter for set_notification call (ping_gpssystem_interval) to minTimeout value from hash.

@jtara
Copy link
Author

jtara commented May 28, 2015

@jtara
Copy link
Author

jtara commented May 28, 2015

Oh! Just plain not implemented! It doesn't punt to set_notification. It just does nothing! AND throws an error because of the third parameter...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants