Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test: rpm-ostree-container-luks #1119

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

jikortus
Copy link
Contributor

@jikortus jikortus commented Apr 2, 2024

It is built on top of @rvykydal's PR #1116 and might need to be reshuffled a bit/rebased (after PR #1116 gets merged) to be suitable for merging into master.

@jikortus jikortus force-pushed the ostreecontainer-luks branch 2 times, most recently from c19db78 to 749a53b Compare April 4, 2024 08:13
@rvykydal rvykydal self-assigned this Apr 9, 2024
@jikortus jikortus force-pushed the ostreecontainer-luks branch from 749a53b to 5bc42c0 Compare April 11, 2024 15:48
@jikortus jikortus force-pushed the ostreecontainer-luks branch from 5bc42c0 to ed1627a Compare April 11, 2024 15:53
@jikortus
Copy link
Contributor Author

@rvykydal, sorry for the delay - I rebased the PR and retested it with RHEL-9 and Fedora, hope it will be OK :-).

@rvykydal
Copy link
Contributor

/test-platforms

Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot! :)

@jikortus
Copy link
Contributor Author

@rvykydal @M4rtinK Thank you for the reviews! Could you please merge the PR now that it got an approval from you? Thank you!

@rvykydal rvykydal merged commit 746641a into rhinstaller:master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants