Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL 10 platform support #1070

Merged

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Feb 28, 2024

For RHEL 10 adds:

  • default repositories
  • platform ks fragments

With the PR it should be possible to run kstests with RHEL 10 boot.iso locally updating the KSTEST_URL - it is still empty, so marking as DRAFT.

PRs for adding rhel10 scenario for daily runs (#1071) and workflow for test on PR on rhel-10 anaconda branch will follow.

@rvykydal rvykydal added the blocked This can't be merged before dependencies! label Feb 28, 2024
@rvykydal rvykydal force-pushed the add-support-for-rhel10-platform branch from 1e28979 to 5ca779f Compare March 6, 2024 14:20
KKoukiou
KKoukiou previously approved these changes Mar 6, 2024
@@ -0,0 +1,6 @@
# Validate installed packages on RHEL 10 system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these copied from somewhere? Should they maybe be symlinks to some common files?

Just asking for possible followup improvements, not nacking this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, I think we haven't been using (modifying) this structure enough to start thinking about it yet (copied the stuff so far).
This fragment would be shared between three rhel platforms (rhel8, rhel9, rhel10 ) so maybe we could create a rhel folder as a target for symlinks (or link to rhel8?).
I'd be a bit afraid of trying to be generic at too high cost at this point, but we can track it as a potential follow-up issue.

source network-device-names.cfg
export KSTEST_URL='http://download.eng.bos.redhat.com/rhel-10/nightly/RHEL-10/latest-RHEL-10.0.0/compose/BaseOS/x86_64/os/'
export KSTEST_MODULAR_URL='http://download.eng.bos.redhat.com/rhel-10/nightly/RHEL-10/latest-RHEL-10.0.0/compose/AppStream/x86_64/os/'
export KSTEST_FTP_URL='ftp://ftp.tu-chemnitz.de/pub/linux/fedora/linux/development/rawhide/Everything/$basearch/os/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this non-standard mirror ok for the ftp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not, but we don't have a better one. The ftp test (the one using this var) is disabled on rhel.

@KKoukiou KKoukiou dismissed their stale review March 6, 2024 14:26

Let's wait for tests, I am not aware if this change is complete.

@rvykydal rvykydal force-pushed the add-support-for-rhel10-platform branch from 5ca779f to 0575ae3 Compare March 12, 2024 12:30
@rvykydal
Copy link
Contributor Author

Updated the paths to repositories.

@rvykydal rvykydal removed the blocked This can't be merged before dependencies! label Mar 12, 2024
@rvykydal rvykydal marked this pull request as ready for review March 12, 2024 12:49
@rvykydal rvykydal requested review from jkonecny12 and jstodola March 12, 2024 12:58
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

For RHEL 10 adds:
- default repositories
- platform ks fragments
@rvykydal rvykydal force-pushed the add-support-for-rhel10-platform branch from 0575ae3 to fa3046c Compare March 12, 2024 15:50
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we fine with the broken link for ostree tests?

@@ -0,0 +1 @@
ostreecontainer --no-signature-verification --transport=registry --url=quay.io/centos-bootc/centos-bootc:stream10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not available and probably won't be anytime soon, so tests depending on this fragment will fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok, we will see it and address it separately.

@rvykydal
Copy link
Contributor Author

rvykydal commented Mar 13, 2024

Are we fine with the broken link for ostree tests?

Yes we are, first lets's run the tests, then look at what is failing, why, and update or disable tests, or create issues to address the failures for rhel10

@rvykydal rvykydal requested a review from jkonecny12 March 14, 2024 08:25
@rvykydal rvykydal merged commit 3051110 into rhinstaller:master Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants