-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RHEL 10 platform support #1070
Add RHEL 10 platform support #1070
Conversation
1e28979
to
5ca779f
Compare
@@ -0,0 +1,6 @@ | |||
# Validate installed packages on RHEL 10 system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these copied from somewhere? Should they maybe be symlinks to some common files?
Just asking for possible followup improvements, not nacking this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, I think we haven't been using (modifying) this structure enough to start thinking about it yet (copied the stuff so far).
This fragment would be shared between three rhel platforms (rhel8, rhel9, rhel10 ) so maybe we could create a rhel folder as a target for symlinks (or link to rhel8?).
I'd be a bit afraid of trying to be generic at too high cost at this point, but we can track it as a potential follow-up issue.
source network-device-names.cfg | ||
export KSTEST_URL='http://download.eng.bos.redhat.com/rhel-10/nightly/RHEL-10/latest-RHEL-10.0.0/compose/BaseOS/x86_64/os/' | ||
export KSTEST_MODULAR_URL='http://download.eng.bos.redhat.com/rhel-10/nightly/RHEL-10/latest-RHEL-10.0.0/compose/AppStream/x86_64/os/' | ||
export KSTEST_FTP_URL='ftp://ftp.tu-chemnitz.de/pub/linux/fedora/linux/development/rawhide/Everything/$basearch/os/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this non-standard mirror ok for the ftp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not, but we don't have a better one. The ftp test (the one using this var) is disabled on rhel.
Let's wait for tests, I am not aware if this change is complete.
5ca779f
to
0575ae3
Compare
Updated the paths to repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
For RHEL 10 adds: - default repositories - platform ks fragments
0575ae3
to
fa3046c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we fine with the broken link for ostree tests?
@@ -0,0 +1 @@ | |||
ostreecontainer --no-signature-verification --transport=registry --url=quay.io/centos-bootc/centos-bootc:stream10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not available and probably won't be anytime soon, so tests depending on this fragment will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's ok, we will see it and address it separately.
Yes we are, first lets's run the tests, then look at what is failing, why, and update or disable tests, or create issues to address the failures for rhel10 |
For RHEL 10 adds:
With the PR it should be possible to run kstests with RHEL 10 boot.iso locally updating the KSTEST_URL - it is still empty, so marking as DRAFT.PRs for adding rhel10 scenario for daily runs (#1071) and workflow for test on PR on rhel-10 anaconda branch will follow.