Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script scanning weekly report logs for existing issues #1008

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Add script scanning weekly report logs for existing issues #1008

merged 1 commit into from
Oct 2, 2023

Conversation

rvykydal
Copy link
Contributor

No description provided.

@rvykydal rvykydal force-pushed the add-script-for-classifying-failures branch from c636067 to d7df78c Compare September 21, 2023 13:03
VladimirSlavik
VladimirSlavik approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this should be very useful.

I am a bit confused by the message format, there's often multiple [numbers] or some in parens, but I guess that would be understandable once I actually looked at these issues?

scripts/classify-failures Outdated
),
(
# The detection may be improved, not sure if just with grep.
"[1] https://github.com/rhinstaller/kickstart-tests/issues/675 The string is also in successful installation, but there is high chance that for test which times out it will be this issue.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this - is it [1] or [675] ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it to [675] (the [1] is obsolete tracking)

@rvykydal
Copy link
Contributor Author

rvykydal commented Oct 2, 2023 •
edited
Loading

Thank you, this should be very useful.

I am a bit confused by the message format, there's often multiple [numbers] or some in parens, but I guess that would be understandable once I actually looked at these issues?

Yes, it is free-form, ideally starting with [NNN] referring to the GH issue https://github.com/rhinstaller/kickstart-tests/issues/NNN. I put former tracking numbers (NNN < 100 in weekly reports) of the issue in parens. And multiple references are for issues that are perhaps the same issue in fact.
The tracking needs still a bit of cleanup or creating of Issues in GH repo (for example the [6] I think).

Any useful comment for a human looking at kstest results/logs can go to the message.

@rvykydal rvykydal force-pushed the add-script-for-classifying-failures branch from d7df78c to d8d6070 Compare October 2, 2023 11:36
@rvykydal rvykydal merged commit 5e684e6 into rhinstaller:master Oct 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvykydal @VladimirSlavik