Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some manual storage tests for new minimal ESP size (500MB) #1002

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Sep 6, 2023

Related to this change:
rhinstaller/anaconda@c253390

Minimum size increased by 300MB.

The reason why the tests are manual (and therefore rot a bit not being run daily) are that libvirt has troubles getting the RESULT from the installer image, therefore manual check is needed.

From my local testing seems we can make part-luks-* automatic, I'll follow on it.
I've checked the patch locally, I guess the CI will fail, maybe except for part-luks-*.

Should fix: #1000

Related to this change:
rhinstaller/anaconda@c253390

Minimum size increased by 300MB.

The reason why the tests are manual (and therefore rot a bit not being
run daily) are that libvirt has troubles getting the RESULT from the
installer image, therefore manual check is needed.

From my local testing seems we can make part-luks-* automatic,
I'll follow on it.
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rvykydal
Copy link
Contributor Author

rvykydal commented Sep 7, 2023

From my local testing seems we can make part-luks-* automatic, I'll follow on it.

#1004

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rvykydal rvykydal merged commit 9210740 into rhinstaller:master Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix manual *-luks-* test
2 participants