Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "payload: raise exception on non zero exit code from rsync" #6029

Closed

Conversation

AdamWill
Copy link
Contributor

This reverts commit 44bde41. It is causing KDE live installs to fail (as it seems rsync has been exiting non-zero on KDE live installs, but without causing any apparent problems in the installed system).

resolves: rhbz#2329379

This reverts commit 44bde41. It
is causing KDE live installs to fail (as it seems rsync has been
exiting non-zero on KDE live installs, but without causing any
apparent problems in the installed system).

resolves: rhbz#2329379
@github-actions github-actions bot added the f42 Fedora 42 label Nov 28, 2024
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fond of reverting this, as we suspect that was covering a lot of failures in anaconda. Let's rather debug the KDE failure, which is deterministically reproduceable at least for open QA.

@KKoukiou
Copy link
Contributor

This is obsoleted from: #6030 which i personally prefer. Please comment with any concerns on #6030

@KKoukiou KKoukiou closed this Nov 29, 2024
@AdamWill
Copy link
Contributor Author

thanks, I'll backport #6030 and test that on openQA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f42 Fedora 42
Development

Successfully merging this pull request may close these issues.

2 participants