Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bond no default wired connection r9 #5704

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Bond no default wired connection r9 #5704

merged 2 commits into from
Aug 7, 2024

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Jun 16, 2024 •
edited
Loading

Upstream PR: #5703. This PR differs only in terminology (slaves/ports)

@pep8speaks
Copy link

pep8speaks commented Jun 16, 2024 •
edited
Loading

Hello @rvykydal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-20 13:49:52 UTC

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype network

@rvykydal
Copy link
Contributor Author

/kickstart-test network-bootopts-team-dhcp-httpks

@rvykydal rvykydal mentioned this pull request Jun 18, 2024
Merged
@rvykydal rvykydal force-pushed the bond-no-default-wired-connection-r9 branch from 7247a1c to b474a54 Compare June 20, 2024 10:21
@rvykydal rvykydal force-pushed the bond-no-default-wired-connection-r9 branch from b474a54 to 3d15328 Compare June 20, 2024 13:49
@rvykydal rvykydal marked this pull request as ready for review June 23, 2024 08:12
@rvykydal rvykydal added the blocked Don't merge this pull request! label Jun 23, 2024
@rvykydal
Copy link
Contributor Author

Waiting for planning into RHEL 9 release.

@rvykydal
Copy link
Contributor Author

Waiting for planning into RHEL 9 release.

Planned for rhel 9.6

@rvykydal rvykydal removed the blocked Don't merge this pull request! label Jul 25, 2024
@rvykydal
Copy link
Contributor Author

Waiting for planning into RHEL 9 release.

Planned for rhel 9.6

So 9.5.

@rvykydal
Copy link
Contributor Author

/kickstart-test --kstest-pr 1267 --testtype network

@rvykydal rvykydal requested a review from jkonecny12 July 25, 2024 13:09
@rvykydal rvykydal requested review from M4rtinK and KKoukiou July 31, 2024 09:23
@rvykydal
Copy link
Contributor Author

rvykydal commented Aug 2, 2024

/kickstart-test --kstest-pr 1267 --testtype network

M4rtinK
M4rtinK approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. :)

@rvykydal rvykydal added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Aug 7, 2024
@rvykydal
Copy link
Contributor Author

rvykydal commented Aug 7, 2024

/kickstart-test --testtype smoke

@rvykydal rvykydal merged commit ad7be3d into rhinstaller:rhel-9 Aug 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@M4rtinK M4rtinK M4rtinK approved these changes

@KKoukiou KKoukiou Awaiting requested review from KKoukiou

Assignees
No one assigned
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rvykydal @pep8speaks @M4rtinK @jkonecny12 @KKoukiou