Consider network spoke complete also in connecting state. #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fixup of commit 16dde60. Network spoke has always been considered completed also if there was a device in connecting state, not only when in connected state.
rvykydal
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
In case of connection with slow activation (the bridge) automated kickstart installation is stopped, either in early network standalone spoke rhinstaller/kickstart-tests#1046 (comment) or if it is patched, in normal network spoke: |
|
/kickstart-test --testtype smoke |
rvykydal
changed the title
M4rtinK
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #5394 which caused this kickstart-test failure:
rhinstaller/kickstart-tests#1046