liveinst: bubble more user env variables through anaconda to the webui #5397
Conversation
In particular, we need XDG_CURRENT_DESKTOP, but this commit brings it all through, so firefox runs in an environment as close to getting run directly by the live user as possible.
|
Split out of #5058 to check the CI. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| readarray -t user_environment < <(pkexec --user "${INSTALLER_USER}" env XDG_RUNTIME_DIR="/run/user/${PKEXEC_UID}" systemctl --user show-environment) | ||
|
|
||
| for variable in "${user_environment[@]}"; do | ||
| export "$variable" |
Check warning
Code scanning / shellcheck
This does not export 'variable'. Remove $/${} for that, or use ${var?} to quiet. Warning
| @@ -22,13 +22,18 @@ | |||
| # unprivileged, restart running as root. | |||
| if [ "$(id -u)" -ne 0 ]; then | |||
| xhost +si:localuser:root | |||
| unset XAUTHORITY | |||
There was a problem hiding this comment.
Just to be sure, all these changes work also on non-WebUI Live media, right?
There was a problem hiding this comment.
I still need to test all, Web UI and others - moved the PR to Draft to clarify this is a work in progress.
It's more like fresh version of #5058 so that I can generate some images and test, as I can't do it locally.
|
This PR is stale because it has been open 60 days with no activity. |
|
This is not tested and I dont have time for this right now. |
In particular, we need XDG_CURRENT_DESKTOP, but this commit brings it all through, so firefox runs in an environment as close to getting run directly by the live user as possible.