-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove instperf" #5356
Revert "Remove instperf" #5356
Conversation
This reverts commit 359c9e7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to also document why this script stays and take responsibility for its maintenance.
from subprocess import Popen, PIPE | ||
import time | ||
|
||
# grab the top five memory consuming processes, returning them in a string of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please extend the comment with information that we have about this script and its use cases?
mem_logger = logging.getLogger("memLog") | ||
mem_logger.setLevel(logging.DEBUG) | ||
|
||
handler = logging.FileHandler("/tmp/memory.dat") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a simple kickstart test for this script, please? I think it might be enough to start an installation with the debug
kernel option, check if the instperf
service is running and make sure that /tmp/memory.dat
is not empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use mkstmp because using /tmp ended up causing problems #5375
This reverts commit 359c9e7.
See #5299 (comment)