Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: automate koji build and bodhi update actions with packit #5354

Merged
merged 1 commit into from
Dec 15, 2023
Merged

infra: automate koji build and bodhi update actions with packit #5354

merged 1 commit into from
Dec 15, 2023
+20 −2

Conversation

KKoukiou
Copy link
Contributor

No description provided.

@KKoukiou KKoukiou added the infrastructure Changes affecting mostly infrastructure label Nov 28, 2023
@github-actions GitHub Actions
Copy link

Infrastructure check failed on these files. Please do a double check of these files before merge!

docs/release.rst

VladimirSlavik
VladimirSlavik reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! A couple of points:

  • The file is templated, you need to edit the .j2. Also, make sure that each branch then gets the right dist-git branch etc.
  • I think the docs should say that Packit does this, and then include the manual steps in case of failure.

.packit.yml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Infrastructure check failed on these files. Please do a double check of these files before merge!

docs/release.rst

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Dec 6, 2023

@VladimirSlavik are the failures relevant? seems like not?

@VladimirSlavik
Copy link
Contributor

Absolutely irrelevant. Infrastructure check tries to ensure that only infrastructure changes (see .structure-config) happen in the PR with label "infrastructure".

VladimirSlavik
VladimirSlavik previously approved these changes Dec 7, 2023
View reviewed changes
@VladimirSlavik VladimirSlavik dismissed their stale review December 7, 2023 13:42

Templates do not match

VladimirSlavik
VladimirSlavik suggested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in the upstream repo, but in dist-git. From https://packit.dev/docs/configuration/downstream/koji_build :

A Packit config file needs to be in the dist-git repository to allow this job to be triggered.

@KKoukiou KKoukiou closed this Dec 12, 2023
@KKoukiou KKoukiou deleted the koji-bodhi-auto branch December 12, 2023 10:57
@KKoukiou KKoukiou restored the koji-bodhi-auto branch December 12, 2023 11:03
@KKoukiou KKoukiou reopened this Dec 12, 2023
@github-actions GitHub Actions
Copy link

Infrastructure check failed on these files. Please do a double check of these files before merge!

docs/release.rst

@KKoukiou
Copy link
Contributor Author

This should not be in the upstream repo, but in dist-git. From https://packit.dev/docs/configuration/downstream/koji_build :

A Packit config file needs to be in the dist-git repository to allow this job to be triggered.

The packit config file is in the upstream repository and it's auto-synced to the dist-git. https://packit.dev/docs/configuration#files_to_sync

So the while packit configuration belongs to the upstream packit.cfg.

@github-actions GitHub Actions
Copy link

Infrastructure check failed on these files. Please do a double check of these files before merge!

docs/release.rst

@KKoukiou KKoukiou force-pushed the koji-bodhi-auto branch 2 times, most recently from 44b928c to fb44a6d Compare December 12, 2023 15:48
@github-actions GitHub Actions
Copy link

Infrastructure check failed on these files. Please do a double check of these files before merge!

docs/release.rst

@github-actions GitHub Actions
Copy link

Infrastructure check failed on these files. Please do a double check of these files before merge!

docs/release.rst

VladimirSlavik
VladimirSlavik approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive infra

@KKoukiou KKoukiou merged commit 2ae5336 into rhinstaller:master Dec 15, 2023
15 checks passed
@KKoukiou KKoukiou deleted the koji-bodhi-auto branch December 15, 2023 16:40
@jkonecny12
Copy link
Member

Sorry for late comment but is there a reason to not enable this also for all supported Fedoras? Packit have an alias for that from what I remember.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Jan 3, 2024

@jkonecny12 I believe it's enabled e52952e#diff-553da68308bd33d94ee7dfc179ad50968916c37c7a58452f707454e918724015R88 on the template file.

Of course now we are on master branch so the rawhide was only affected. When we branch out fedora-40 it will be updated correctly.

@jkonecny12
Copy link
Member

jkonecny12 commented Jan 3, 2024 •
edited
Loading

I see. Thanks for answer.
Even though my question was more about enablement in Packit don't need special casing in templates but both works for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
documentation f40 infrastructure Changes affecting mostly infrastructure
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKoukiou @VladimirSlavik @jkonecny12