Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootloader: Create an installation task for collecting kernel arguments #5350

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

poncovka
Copy link
Contributor

Use the CollectKernelArgumentsTask task to collect kernel arguments
for the installation. This will be used by the bootupd support that needs
to be able to collect kernel arguments without installing the bootloader.
See: #5298 (comment)).

Move the implementation to the `InstallBootloaderTask` class.
Add a new method for collecting kernel arguments for the installation.
@pep8speaks
Copy link

pep8speaks commented Nov 28, 2023

Hello @poncovka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-28 12:12:53 UTC

Use the `CollectKernelArgumentsTask` task to collect kernel arguments
for the installation. It will be used by the bootupd support that needs
to be able to collect kernel arguments without installing the bootloader.
@poncovka
Copy link
Contributor Author

/kickstart-test --testtype smoke

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@poncovka
Copy link
Contributor Author

/kickstart-test -t bootloader

@poncovka poncovka merged commit b2006da into rhinstaller:master Nov 28, 2023
17 checks passed
@poncovka poncovka mentioned this pull request Nov 28, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants