Cherry-pick PR 5297 content from Fedora-39 branch #5324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
Hello @KKoukiou! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-02-06 15:45:13 UTC |
|
This needs to be tested with the Web UI |
|
This PR is stale because it has been open 60 days with no activity. |
|
What's the testing that it needs? Is it something that's now available? |
we dont have automation for live images, so that needs to be tested manually. |
|
Oh :( |
Live images are already installed with grub2 and cannot be changed on the fly to systemd-boot (well at least without a lot of extra work). In case the user passed one of the systemd-boot options to anaconda, we should be a bit more graceful than failing to run the updateloader entries script as currently happens. This change, when run on non webUI installs results in a popup notifying the user there is an error in the bootloader configuration and asking if they would like to ignore it. Resolves: rhbz#2234638 Signed-off-by: Jeremy Linton <[email protected]>
The installer is not able to verify requirements of the selected bootloader with other types of payload, like live images and rpmostree installations. Let's allow systemd-boot only for package installations for now and deal with other use cases later. Related: rhbz#2234638
KKoukiou
force-pushed
the
sdboot-cherry-pickpr-5297
branch
from
58b686b
to
a10b1fa
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Something wrong with RPM builds here. Closing and reopening for COPR from packit to be recreated. |
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.