Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: apis: dont repeat yourself #5281

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

KKoukiou
Copy link
Contributor

No description provided.

@KKoukiou KKoukiou added the blocked Don't merge this pull request! label Oct 25, 2023
@KKoukiou KKoukiou force-pushed the webui-api-dont-repeat-yourself branch from 9e6bce5 to 7a67e34 Compare October 25, 2023 15:14
@KKoukiou KKoukiou changed the title Webui api dont repeat yourself webui: apis: dont repeat yourself Oct 25, 2023
@KKoukiou KKoukiou force-pushed the webui-api-dont-repeat-yourself branch 4 times, most recently from cf783f7 to 27f0049 Compare October 26, 2023 14:46
* Get interface and object paths from variables
* Use helper functions for calling dbus methods

The latter allowed us to have consistent handling of the return values from DBus
calls; we now unpack the result from the contained array directly after
the call, not in the caller function.
@KKoukiou KKoukiou force-pushed the webui-api-dont-repeat-yourself branch from 27f0049 to ab15aa0 Compare October 27, 2023 07:47
@KKoukiou KKoukiou removed the blocked Don't merge this pull request! label Oct 27, 2023
@KKoukiou KKoukiou marked this pull request as ready for review October 27, 2023 08:44
Copy link
Contributor

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KKoukiou
Copy link
Contributor Author

/kickstart-test --waive webui-only

@KKoukiou KKoukiou merged commit a70ac7c into rhinstaller:master Oct 30, 2023
19 checks passed
@KKoukiou KKoukiou deleted the webui-api-dont-repeat-yourself branch October 30, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants