Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for advanced storage: WWID for multipath, path-id for zfcp, generate zfcp kickstart #5249

Closed

Commits on Oct 30, 2023

  1. fix missing WWID values for multipath devices in advanced storage UI …

    …(#2046654)
    
    Multipath devices themselves do not have a path-id but only their path
    members. In that case, a good volume identifier is the WWID/WWN/UUID.
    
    Fixes: 8e75893 ("Remove the local storage object from the advanced storage spoke")
    Signed-off-by: Steffen Maier <[email protected]>
    steffen-maier committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    1202272 View commit details
    Browse the repository at this point in the history
  2. DeviceTreeViewer: Add path-id attribute to zfcp-attached SCSI disks

    Currently, the UI prints the kernel device names for
    multipath path members. Kernel device names are unpredictable and
    non-persistent and thus hardly suitable as path identifier for users.
    
    This is a preparation providing backend data to be used in a future commit
    to show in the UI.
    
    FCoE, iSCSI, and NVDIMM already have the attribute since commit
    e74030e ("Add the path-id attribute to the DBus structure for device
    data"). Provide the same for zfcp-attached SCSI disks, which should always
    be used with multipathing.
    
    This change tolerates the absence of the id_path attribute if the
    corresponding change adding the attribute in blivet does not exist.
    
    Signed-off-by: Steffen Maier <[email protected]>
    steffen-maier committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    1ce59b9 View commit details
    Browse the repository at this point in the history
  3. fix missing emit of zfcp kickstart statements

    As user I expect that I can re-run the installation unattendedly when using
    the generated kickstart file of an interactive installation run
    (using the same installer boot options plus inst.ks=).
    Meanwhile, only those zfcp statements from a kickstart file provided as
    input for an installation run were also written into the generated
    kickstart file.
    Fix the missing zfcp statements in the generated kickstart file
    that originate in user interactions on the storage screen UI.
    
    Fixes: d819bb9 ("Remove unused writeKS methods.")
    Fixes: 0d76185 ("Remove all the writeKS methods except in network and storage.")
    Signed-off-by: Steffen Maier <[email protected]>
    steffen-maier committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3363266 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Require blivet version for test

    rvykydal authored and steffen-maier committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    1c274c4 View commit details
    Browse the repository at this point in the history