Master add iso builds to templates #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infrastructure
|
/kickstart-test --testtype smoke |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@VladimirSlavik seems that the ShellCheck has issues with our templating solution. Should I somehow bypass the check there? |
|
Resolved the missing bot requirement: cockpit-project/bots#5176 |
|
I think we need something like this: - id: ShellCheck
name: Differential ShellCheck
uses: redhat-plumbers-in-action/differential-shellcheck@v4
with:
severity: warning
token: ${{ secrets.GITHUB_TOKEN }}
+ exclude-path: '*.j2'Maybe it would run on the PR if it is changed with it? Also, it can have multiple values, so maybe it will bring the same globbing fun as the autolabeling did... (just a pessimistic guess) |
jkonecny12
force-pushed
the
master-add-iso-builds-to-templates
branch
from
d7937c4
to
1529bf3
Compare
|
/kickstart-test --testtype smoke |
VladimirSlavik
approved these changes
Aug 30, 2023
jkonecny12
force-pushed
the
master-add-iso-builds-to-templates
branch
from
1529bf3
to
a392e76
Compare
|
UPDATED
|
|
/kickstart-test --testtype smoke |
We need to add the build scripts into our templating solution.
We need to add script and Dockerfile to our templating solution.
The j2 files are our templating and these are not usual shell scripts.
jkonecny12
force-pushed
the
master-add-iso-builds-to-templates
branch
from
a392e76
to
d478eac
Compare
|
/kickstart-test --testtype smoke |
|
UPDATED
|
VladimirSlavik
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ISO build to take branched Fedora sources instead of Rawhide.
Backport of #5098