infra: Build also live and updates images #5071
Conversation
github-actions
bot
added
infrastructure
VladimirSlavik
force-pushed
the
master-live-action
branch
2 times, most recently
from
b578fd4
to
e2598c9
Compare
VladimirSlavik
added
the
manual testing required
VladimirSlavik
force-pushed
the
master-live-action
branch
from
e2598c9
to
ceadb3e
Compare
|
Rebased to allow testing on my fork. A bunch of pushes will follow, sorry for the noise. |
VladimirSlavik
force-pushed
the
master-live-action
branch
4 times, most recently
from
2c0d639
to
098a328
Compare
|
Tested piecewise at VladimirSlavik#117. Very lovely. Now also with 100% more updates.img. |
VladimirSlavik
force-pushed
the
master-live-action
branch
from
098a328
to
d46219b
Compare
VladimirSlavik
removed
the
manual testing required
|
/kickstart-test --waive infra only |
|
/webui-test --waive infra only |
|
Hm, nice, the webui tests do not have correct status name. Not for this PR though. |
VladimirSlavik
changed the title
|
/webui-test --waive infra only |
|
|
||
| - name: Create updates image | ||
| run: | | ||
| ./scripts/makeupdates |
There was a problem hiding this comment.
Hopefully this will work. Without the tag specification it takes the latest which might be problematic in some cases. Also outdated PR might broke this even more.
I wonder if building RPMs and just adding them to the updates image wouldn't be better solution.
In any case, great improvement - just a bit fragile.
There was a problem hiding this comment.
Agreed; if people start using this, perhaps it can do the rebase, same as tests. However in the first approximation I wanted to stay consistent, none of the other image builds rebase. Which might be a problem, now that I think about it... Well, another PR.
Now run it from comment as: /build-image [--boot.iso] [--live] [--webui]
To do so: /build-image --updates.img
VladimirSlavik
force-pushed
the
master-live-action
branch
from
d46219b
to
2dc3903
Compare
|
/kickstart-test --waive infra only |
|
/webui-test --waive infra only |
Previous syntax:
/boot-iso [--webui]New syntax:
/build-image [--boot.iso] [--live] [--webui] [--updates.img]--webuimodifies boot.iso to use webui/build-iso --boot.iso --livewill build two imagesStacking with changes from #5052 for now.