infra: Clone repo for cockpit lib update with token #4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infrastructure
KKoukiou
reviewed
Jul 13, 2023
| @@ -24,6 +25,8 @@ jobs: | |||
|
|
|||
| - name: Clone repository | |||
| uses: actions/checkout@v3 | |||
| with: | |||
| token: ${{ secrets.INSTALLKER_TOKEN }} | |||
There was a problem hiding this comment.
I think you have a typo here? INSTALLKER?
Also the fact that we can't update is not making this PR blocked. We can nicely generate the PRs just not merge them.
There was a problem hiding this comment.
That's the bot name, so its token has its name.
|
Yup, not a high priority, just wanted to dump it here as a PR instead of a random comment hidden somewhere. |
|
I think let's try and see what this does. Usually, we catch the issues with opening PRs later after we deploy the code. The interaction with other tokens used throughout the whole process is unclear, so I don't see testing it as economical... |
|
/kickstart-test --waive infra only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #4790 (comment)
It's not clear if this solves the problem.
Currently blocked because we can't update.