Skip to content

Commit

Permalink
fix missing emit of zfcp kickstart statements
Browse files Browse the repository at this point in the history
As user I expect that I can re-run the installation unattendedly when using
the generated kickstart file of an interactive installation run
(using the same installer boot options plus inst.ks=).
Meanwhile, only those zfcp statements from a kickstart file provided as
input for an installation run were also written into the generated
kickstart file.
Fix the missing zfcp statements in the generated kickstart file
that originate in user interactions on the storage screen UI.

Fixes: d819bb9 ("Remove unused writeKS methods.")
Fixes: 0d76185 ("Remove all the writeKS methods except in network and storage.")
Signed-off-by: Steffen Maier <[email protected]>
  • Loading branch information
steffen-maier committed Oct 16, 2023
1 parent fc849d1 commit 68b054b
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions pyanaconda/modules/storage/zfcp/zfcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,15 @@ def process_kickstart(self, data):
def setup_kickstart(self, data):
"""Setup the kickstart data."""
data.zfcp.zfcp = self._zfcp_data
# So far, the data contains explicit zfcp statements from a
# kickstart file used as input for the installation. Now, add any
# missing entries that come from user interaction with the GUI.
for fcpdev in zfcp.fcpdevs:
zd = data.zfcp.dataClass()
zd.devnum = fcpdev.devnum
if "wwpn" in dir(fcpdev):
zd.wwpn = fcpdev.wwpn
if "fcplun" in dir(fcpdev):
zd.fcplun = fcpdev.fcplun
if zd not in data.zfcp.dataList():
data.zfcp.dataList().append(zd)

0 comments on commit 68b054b

Please sign in to comment.