Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make boot not required #95

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Dec 11, 2023

Depends on Anaconda backend API update: rhinstaller/anaconda#5372

@rvykydal
Copy link
Contributor Author

The second commit Use the "encryption-allowed" constraint in UI checks
is independent of this update and leverages already present constraints in the device selection element:
Screenshot from 2023-12-08 09-47-02
instead of failing on the final check on 'Next':
Screenshot from 2023-12-08 09-46-35

@rvykydal
Copy link
Contributor Author

rvykydal commented Dec 11, 2023

@KKoukiou - trying to run the CI with the anaconda dependency (rhinstaller/anaconda#5372):

[rvykydal@prnot4 ~/work/git/rvykydal/anaconda-webui.1 (make-boot-not-required)]$ bots/tests-trigger 95 fedora-rawhide-boot/anaconda-pr-5372@rhinstaller/anaconda-webui
95 is not a pull request.

@rvykydal
Copy link
Contributor Author

@KKoukiou - trying to run the CI with the anaconda dependency (rhinstaller/anaconda#5372):

[rvykydal@prnot4 ~/work/git/rvykydal/anaconda-webui.1 (make-boot-not-required)]$ bots/tests-trigger 95 fedora-rawhide-boot/anaconda-pr-5372@rhinstaller/anaconda-webui
95 is not a pull request.

This was caused by origin pointing to my fork, using --repo rhinstaller/anaconda-webui fixes the issue.

@rvykydal rvykydal force-pushed the make-boot-not-required branch from f1e4bbc to 698300c Compare December 11, 2023 15:42
@rvykydal
Copy link
Contributor Author

rvykydal commented Dec 11, 2023

Seems like the backend changes are not getting into the tests (the missing API in https://cockpit-logs.us-east-1.linodeobjects.com/pull-95-20231211-154510-698300cc-fedora-rawhide-boot-anaconda-pr-5372-rhinstaller-anaconda-webui/log.html). Locally the PRs work for me using updates.img from anaconda (script/makeupdates) merged into updates.img from webui (make create-updates.img).

@rvykydal rvykydal force-pushed the make-boot-not-required branch from 698300c to a452f44 Compare December 13, 2023 07:18
@KKoukiou
Copy link
Contributor

#100 will fix the test failures: #100

@KKoukiou KKoukiou force-pushed the make-boot-not-required branch from a452f44 to f0859f5 Compare December 14, 2023 12:57
@rvykydal rvykydal marked this pull request as ready for review December 15, 2023 10:30
@KKoukiou KKoukiou removed the blocked label Jan 3, 2024
@KKoukiou KKoukiou force-pushed the make-boot-not-required branch from 3c022ad to af47dfc Compare January 4, 2024 14:22
@KKoukiou
Copy link
Contributor

KKoukiou commented Jan 9, 2024

Pasting current failing test run for ELN and re-triggering for comparison. https://cockpit-logs.us-east-1.linodeobjects.com/pull-95-20240108-190535-af47dfc6-fedora-eln-boot/log.html

@rvykydal rvykydal force-pushed the make-boot-not-required branch 2 times, most recently from 96bca95 to bd64f2d Compare January 15, 2024 14:01
@KKoukiou KKoukiou force-pushed the make-boot-not-required branch 2 times, most recently from d89cc69 to 8ad3c71 Compare January 16, 2024 08:31
@rvykydal rvykydal force-pushed the make-boot-not-required branch from 8ad3c71 to 6c7300e Compare January 19, 2024 12:09
Switch to unified GetMountPointConstraints API.
@KKoukiou KKoukiou force-pushed the make-boot-not-required branch from 6c7300e to f318a46 Compare January 29, 2024 12:13
@KKoukiou KKoukiou force-pushed the make-boot-not-required branch from f318a46 to bd218ae Compare January 29, 2024 13:14
@KKoukiou KKoukiou merged commit f80363e into rhinstaller:main Jan 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants