Tests for NewProject module #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanjos
suggested changes
May 24, 2019
test/test_helper.exs
Outdated
| @@ -1,4 +1,6 @@ | |||
| Mox.defmock(Slax.HttpMock, for: Slax.Http.Behaviour) | |||
| Mox.defmock(Slax.Commands.GithubCommandsMock, for: Slax.Commands.GithubCommands.Behaviour) | |||
| Slax.Command.GithubCommandMock | |||
There was a problem hiding this comment.
Suggested change
| Slax.Command.GithubCommandMock |
HoffsMH
force-pushed
the
new-project-testing
branch
from
1dc16d5
to
b475e62
Compare
|
@bryanjos updated 👍 |
bryanjos
approved these changes
May 24, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP
Connects to #48 increases code coverage for creating a new project!
Since I have another PR open for increasing code coverage for the
GithubCommandsmodule I made a mock for that module.This doesn't yet cover all the paths in project creation, still need to cover when creating web-hooks fail.
It definitely feels a little iffy to be specifying this amount of Mox expectations in each test. If there is another pattern that would work here I am all ears!