Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer - increase test coverage > 75% #48

Open
radditude opened this issue Feb 19, 2019 · 1 comment
Open

Developer - increase test coverage > 75% #48

radditude opened this issue Feb 19, 2019 · 1 comment

Comments

@radditude
Copy link
Contributor

Currently test coverage is ~40%. Let's boost that to over 75%.
@bryanjos
Copy link
Contributor

bryanjos commented Feb 19, 2019 •
edited
Loading

I think #49 and #50 will help towards that

bryanjos added a commit that referenced this issue Feb 21, 2019
@bryanjos
chore: Integrations Refactor
125cd77 
connects to #48

Simplified code by removing indirection to Github and Slack
modules. This was mainly used for subbing in mock modules.
This change instead relies more on bypass to stub http requests
instead of using Mox. Tests are slightly more complicated in some
cases, but also more explicit. This should also allow for code
completion to work on the integration modules.
@bryanjos bryanjos mentioned this issue Feb 21, 2019
Merged
This was referenced May 17, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryanjos @radditude