Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] finishes porting over Stellar XDR types #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sunny-g
Copy link

@sunny-g sunny-g commented Aug 20, 2018

No description provided.

@sunny-g
Copy link
Author

sunny-g commented Aug 20, 2018

No need to merge yet, only for show :)

@grossvogel
Copy link

@sunny-g I noticed this PR uses version 0.2.0 of your XDR package, but I don't see it on hex.pm. Can we expect that to be updated soon?

@sunny-g
Copy link
Author

sunny-g commented Jan 8, 2019

@grossvogel Sorry for that oversight!

0.2.0 currently depends on a fork of ok that's on my github but not on Hex, and as a result, I can't publish it to Hex. What's the recommended process for publishing forks of libraries or libraries with github dependencies?

@grossvogel
Copy link

@sunny-g No worries at all, I appreciate your making the XDR package and helping us out with this project!

I agree with your desire not to a package with github dependencies, and it seems like the best option would be to try to get the patch accepted into ok if it's important. If the patch isn't crucial, maybe there's a workaround that would allow you to stick with the official package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants