Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract action buttons #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: extract action buttons #51

wants to merge 3 commits into from

Conversation

DSIW
Copy link
Collaborator

@DSIW DSIW commented Jun 30, 2024

  • Extract action buttons
  • Move to components

Feature summary

QA checklist

  • Read state (state & power state)
  • Read primary battery SOC
  • Read primary battery cycles
  • Read secondary battery SOC
  • Read secondary battery cycles
  • Read seat closed
  • Read handlebar
  • Read AUX SOC
  • Read CBB SOC
  • Read CBB charging state
  • Update ping
  • SOCs are cached (after app restart)
  • Commands can be sent (locking & hibernation)

} catch (e) {
if (e.toString().contains("SEAT_OPEN")) {
// TODO
// showSeatWarning();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That needs to be fixed in a separate PR related to the issue

@TheFreal
Copy link
Collaborator

TheFreal commented Jul 4, 2024

  1. This feels like really poor style, as it turns what was previously one reusable widget into a whole folder of single-purpose files.
  2. The action buttons will probably change significantly in Home Screen and controls section need a UX rework #43 (which this structure would make way harder)
  3. I'm not yet convinced of the flutter-on-wear approach in its entirety
    For those reasons, I'm not merging for now :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants