Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor bluetooth reading #47

Merged
merged 43 commits into from
Jun 28, 2024
Merged

Refactor bluetooth reading #47

merged 43 commits into from
Jun 28, 2024

Conversation

DSIW
Copy link
Collaborator

@DSIW DSIW commented Jun 25, 2024 •
edited
Loading

  • Extract ScooterReader
  • Extract BatteryReader
  • Extract CharacteristicRepository
  • Remove unused CBB capacity reading

QA checklist

  • Read state (state & power state)
  • Read primary battery SOC
  • Read primary battery cycles
  • Read secondary battery SOC
  • Read secondary battery cycles
  • Read seat closed
  • Read handlebar
  • Read AUX SOC
  • Read CBB SOC
  • Read CBB charging state
  • Update ping
  • SOCs are cached (after app restart)
  • Commands can be sent (locking & hibernation)

DSIW added 30 commits May 3, 2024 08:27
@DSIW
Extract BatteryReader
6ddb412
@DSIW
Extract readers
56e54e6
@DSIW
Extract BT readers
f05eaab
@DSIW
Remove unused CBB capacity reading
9288b09
@DSIW
Move ping to soc reader
6f00b8b
@DSIW
Extract subscribeCharacteristic
29886ca
@DSIW
Remove controller as dependency
001282f
@DSIW
Rename to _characteristic
c2c301e
@DSIW
Remove sharedPrefs dependency
a6d3803
@DSIW
Pass controllers as method parameters
c1501d9
@DSIW
Reformat
b9a65fb
@DSIW
Extract CharacteristicRepository
25d4721
@DSIW
Extract ScooterReader
8022c96
@DSIW
Read soc caches
cb93ca9
@DSIW
Extract SharedPrefKey
7e0bd46
@DSIW
Extract CacheManager
fa7fb3c
@DSIW
Add cache manager tests
8f9e999
@DSIW
Integrate CacheKey into CacheManager
c47db22
@DSIW
Extract ScooterBattery
0ce81b3
@DSIW
Rename to battery
f3e58ca
@DSIW
Improve null pointer handling
1f9046a
@DSIW
Fix CBB SOC state
8327fc9
@DSIW
Reformat
6776725
@DSIW
Add test for StringReader
5ebe09f
@DSIW
Add tests for CycleReader
c116f17
@DSIW
Add tests for CacheManager
2bbb751
@DSIW
Add tests for CycleReader
3403a38
@DSIW
Inline CycleReader
8ef97b8
@DSIW
Inline CacheManager and StateOfChargeReader
066a343
@DSIW
Align battery reading
2826a2d
DSIW added 13 commits May 14, 2024 08:49
@DSIW
Add tests for BatteryReader
78159f6
@DSIW
Add more tests
f4d6f27
@DSIW
Reduce duplication in tests
fd43394
@DSIW
Merge branch 'battery-reader-test' into battery-reader
3de923a 
* battery-reader-test:
  Reduce duplication in tests
  Add more tests
  Add tests for BatteryReader
  Align battery reading
  Inline CacheManager and StateOfChargeReader
  Inline CycleReader
  Add tests for CycleReader
  Add tests for CacheManager
  Add tests for CycleReader
  Add test for StringReader
  Reformat
@DSIW
Move convertUint32ToInt to BatteryReader
289a741
@DSIW
Only send to controller if not null
333dd08
@DSIW
Reformat and clean up
9c13d30
@DSIW
Extract private methods
8258120
@DSIW
Align imports
e6c3393
@DSIW
Extract variables
96bad95
@DSIW
Fix SOC char when reading
90ebf26
@DSIW
Merge branch 'main' into battery-reader
b7bcdfb 
* main:
  Multiscooter backend (#40)
  Update README.md
  Typo
  Adjust changelog
  Cleanup
  Create LICENSE
  Visual fixes, attempting to debug NFC
  Add back NFC for Android
  De-capitalize app name
  Optimistic wording
  Splash screen fix on iOS
  Minor styling fixes
  Wording for smaller screens
  Visual fixes
  Use new side view in range section
  Crop scooter side pictures
  iOS fixes
  Include new side graphic
  Podfile update
  Preparation for light theme. Design upgrades.

# Conflicts:
#	lib/scooter_service.dart
@DSIW
Fix merge
9798e71
@DSIW DSIW marked this pull request as ready for review June 25, 2024 06:46
@DSIW DSIW merged commit 6ed55f8 into main Jun 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DSIW