Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 vulnerabilities in callback handling #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Arie
Copy link

@Arie Arie commented Oct 31, 2024

Fix two vulnerabilities based on the work of the passport-steam node.js library.

  1. Check for the correct ns, identity and claimed_id. See New vulnerability fix liamcurry/passport-steam#120 (comment) for how this was abused.
  2. Check there aren't any extra query parameters in the callback URL. This was used to inject extra parameters containing unicode null bytes, allowing logging in with a steam id of the attacker's choosing. Based on Fix critical vulnerability: Add OpenID query parameter validation liamcurry/passport-steam#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant