Fix: Remove infinite loop in LWD plugin #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbouchar
requested review from
StykMartin,
p3ck,
mdujava,
renanrodrigo and
danrodrig
p3ck
reviewed
Jun 4, 2020
cbouchar
force-pushed
the
issue86-rm-lwd-infinite-loop
branch
from
9b0aa2c to
8cec43b
Compare
|
/test |
cbouchar
force-pushed
the
issue86-rm-lwd-infinite-loop
branch
2 times, most recently
from
1e07f87 to
5b22a2b
Compare
Under given circumstances, it is possible for one of the local watchdog plugins `20_sysinfo` to fall into an infinite loop. Changes were made to reduce the number of loops and to reduce the loop to no more than 2 minutes. Additionally, unnecessary sleep operations have been eliminated. As a result, the plugin will take less time to run. Older RHEL releases like RHEL5 take about 45 seconds to complete reporting while RHEL7 takes about 5 seconds. A max wait time of 2 minutes waiting for system resource reporting is to account for many more processes running than I had and for older operating systems. If still not enough time, an error message will be reported. Issue: 86
cbouchar
force-pushed
the
issue86-rm-lwd-infinite-loop
branch
from
5b22a2b to
fa87a4a
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under given circumstances, it is possible for one of the
local watchdog plugins
20_sysinfoto fall into an infiniteloop. Changes were made to reduce the number of loops and
to reduce the loop to no more than 2 minutes. Additionally,
unnecessary sleep operations have been eliminated. As a result,
the plugin will take less time to run. Older RHEL releases
like RHEL5 take about 45 seconds to complete reporting while
RHEL7 takes about 5 seconds. A max wait time
of 2 minutes waiting for system resource reporting is to
account for many more processes running than I had and for
older operating systems. If still not enough time,
an error message will be reported.
Fix: #86