Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5 nio depreciation #1430

Merged
merged 2 commits into from
Oct 30, 2024
Merged

2.5 nio depreciation #1430

merged 2 commits into from
Oct 30, 2024

Conversation

jlouvel
Copy link
Member

@jlouvel jlouvel commented Oct 28, 2024

The aim

Deprecated NIO flavor of Restlet API for removal in next major release, with plan to use
virtual threads instead to achieve additional scalability and reactive behavior.

The solution

Marked related code as deprecated.

  • PR size
    • Under 300 lines ✅
    • Can't be split without complicating the process even more
  • Tests
    • Added
    • Not applicable (why?)
  • Doc
    • Added
    • Not applicable
  • Reviewer
    • Asked for a review
    • Added label DO NOT REVIEW

      - Deprecated NIO flavor of Restlet API for removal in next major release, with plan to use
        virtual threads instead to achieve additional scalability and reactive behavior.
@jlouvel jlouvel requested a review from thboileau October 28, 2024 04:58
Copy link
Contributor

@thboileau thboileau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlouvel jlouvel merged commit 9e8e8b4 into 2.5 Oct 30, 2024
1 check passed
@jlouvel jlouvel deleted the 2.5-nio-depreciation branch October 30, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants