Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add npm option to allow usage of 'filter-by-workspace-path-plugin' without npm #18

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

Maxim-Durand
Copy link
Contributor

@Maxim-Durand Maxim-Durand commented Mar 7, 2024

Fixes #16

Added "non_npm" usage for the plugin (updated doc too).

@Maxim-Durand
Copy link
Contributor Author

@restfulhead What do you think ?

@restfulhead
Copy link
Owner

@Maxim-Durand I think it's a great idea. Thanks for the contribution. I will review soon.

@restfulhead
Copy link
Owner

@Maxim-Durand Sorry for the delay. I have a small suggestion: Instead of an option non_npm, how about we add an option with_npm or just npm that defaults to true? It gives us flexibility to perhaps add other package managers in future. If you agree, could you make the change? Happy to merge afterwards.

@Maxim-Durand
Copy link
Contributor Author

@restfulhead I made your recommended changes and updated the README.md so it will be easy to add new config params.
I also ran the lint and tests successfully.

@restfulhead
Copy link
Owner

LGTM, thank you! Going to merge and release.

@restfulhead restfulhead changed the title feature: non_npm usage of 'filter-by-workspace-path-plugin' feature: add npm option to allow usage of 'filter-by-workspace-path-plugin' without npm Mar 18, 2024
@restfulhead restfulhead merged commit 97d6027 into restfulhead:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use in non-npm context
2 participants